feat: update ubuntu version to latest#459
feat: update ubuntu version to latest#459Faraz32123 wants to merge 1 commit intoopen-craft:masterfrom
Conversation
|
@Agrendalath As you can see CI failures for first commit, what are your suggestions? |
Faraz32123
force-pushed
the
feat/update_ubuntu_version
branch
10 times, most recently
from
7a25aa5 to
c57ee62
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #459 +/- ##
=======================================
Coverage 45.08% 45.08%
=======================================
Files 40 40
Lines 3309 3309
Branches 463 463
=======================================
Hits 1492 1492
Misses 1769 1769
Partials 48 48
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Faraz32123
force-pushed
the
feat/update_ubuntu_version
branch
5 times, most recently
from
6a5adb2 to
6f77eee
Compare
.github/workflows/ci.yml
Outdated
| sudo apt-get update | ||
| sudo apt-get install -y xvfb | ||
| sudo apt-get install -y libxmlsec1-dev ubuntu-restricted-extras xvfb libgtk-3-0 libdbus-glib-1-2 | ||
| wget https://github.com/mozilla/geckodriver/releases/download/v0.32.2/geckodriver-v0.32.2-linux64.tar.gz |
There was a problem hiding this comment.
@Faraz32123 , this should already be handled in the Makefile. We don't need this in CI scripts and tox config.
There was a problem hiding this comment.
I was checking CI in my fork, It was failing first due to browser related issue and then due to selenium related issue.
I have removed it, yes you are right it's handled in makefile. I was just trying things.
Let me know what to do next if you have some suggestions! Thanks 😀
You can see the current CI failures here: Faraz32123#2
Integration tests are failing!! It will fail with only ubuntu-latest change as well.
Faraz32123
force-pushed
the
feat/update_ubuntu_version
branch
from
d56900e to
6f77eee
Compare
Faraz32123
force-pushed
the
feat/update_ubuntu_version
branch
from
6f77eee to
5fb101b
Compare
|
closing this PR in favor of #458. |
2 participants
No description provided.